Fix the tests

OctopusSolutionsEngineering · Oct 9, 2024 · b92b151 · b92b151
1 parent c83b401
commit b92b151
Show file tree

Hide file tree

Showing 27 changed files with 42 additions and 42 deletions.
diff --git a/internal/checks/naming/octopus_invalid_lifecycle_name_test.go b/internal/checks/naming/octopus_invalid_lifecycle_name_test.go
@@ -37,7 +37,7 @@ func TestLifecyclesInvalidName(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		// Assert
 		if result == nil || result.Severity() != checks.Warning {

diff --git a/internal/checks/naming/octopus_invalid_target_name_test.go b/internal/checks/naming/octopus_invalid_target_name_test.go
@@ -37,7 +37,7 @@ func TestInvalidTargetName(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_invalid_target_role_test.go b/internal/checks/naming/octopus_invalid_target_role_test.go
@@ -37,7 +37,7 @@ func TestInvalidTargetRole(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_invalid_variables_check_test.go b/internal/checks/naming/octopus_invalid_variables_check_test.go
@@ -34,7 +34,7 @@ func TestInvalidVariableNames(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_project_invalid_release_template_test.go b/internal/checks/naming/octopus_project_invalid_release_template_test.go
@@ -37,7 +37,7 @@ func TestInvalidReleaseTemplate(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_project_uses_default_step_names_test.go b/internal/checks/naming/octopus_project_uses_default_step_names_test.go
@@ -35,7 +35,7 @@ func TestDefaultStepNames(t *testing.T) {
 			&config.OctolintConfig{},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_project_uses_invalid_container_image_test.go b/internal/checks/naming/octopus_project_uses_invalid_container_image_test.go
@@ -37,7 +37,7 @@ func TestInvalidContainerImage(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/naming/octopus_project_uses_invalid_worker_pool_test.go b/internal/checks/naming/octopus_project_uses_invalid_worker_pool_test.go
@@ -37,7 +37,7 @@ func TestInvalidWorkerPool(t *testing.T) {
 			},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_default_project_group_count_test.go b/internal/checks/organization/octopus_default_project_group_count_test.go
@@ -30,7 +30,7 @@ func TestNormalProjectCount(t *testing.T) {
 
 		check := NewOctopusDefaultProjectGroupCountCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -63,7 +63,7 @@ func TestExcessiveProjectCount(t *testing.T) {
 
 		check := NewOctopusDefaultProjectGroupCountCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -115,7 +115,7 @@ func TestExcessiveProjectCountWithPermissionsError(t *testing.T) {
 
 		check := NewOctopusDefaultProjectGroupCountCheck(limitedClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_duplicated_variables_check_test.go b/internal/checks/organization/octopus_duplicated_variables_check_test.go
@@ -29,7 +29,7 @@ func TestNoDuplicateVars(t *testing.T) {
 
 		check := NewOctopusDuplicatedVariablesCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestDuplicateVars(t *testing.T) {
 
 		check := NewOctopusDuplicatedVariablesCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_empty_project_check_test.go b/internal/checks/organization/octopus_empty_project_check_test.go
@@ -29,7 +29,7 @@ func TestPopulatedDeploymentProcess(t *testing.T) {
 
 		check := NewOctopusEmptyProjectCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestEmptyDeploymentProcess(t *testing.T) {
 
 		check := NewOctopusEmptyProjectCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_environment_count_check_test.go b/internal/checks/organization/octopus_environment_count_check_test.go
@@ -29,7 +29,7 @@ func TestNormalEnvironmentCount(t *testing.T) {
 
 		check := NewOctopusEnvironmentCountCheck(newSpaceClient, &config.OctolintConfig{MaxEnvironments: 10}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestExcessiveEnvironmentCount(t *testing.T) {
 
 		check := NewOctopusEnvironmentCountCheck(newSpaceClient, &config.OctolintConfig{MaxEnvironments: 10}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_lifecycle_retention_policy_check_test.go b/internal/checks/organization/octopus_lifecycle_retention_policy_check_test.go
@@ -49,7 +49,7 @@ func TestLifecyclesMeetRecommendations(t *testing.T) {
 
 		check := NewOctopusLifecycleRetentionPolicyCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		// Assert
 		if result.Severity() != checks.Ok {
@@ -83,7 +83,7 @@ func TestLifecycleKeepsReleasesForever(t *testing.T) {
 
 		check := NewOctopusLifecycleRetentionPolicyCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -121,7 +121,7 @@ func TestLifecycleKeepsFilesForever(t *testing.T) {
 
 		check := NewOctopusLifecycleRetentionPolicyCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -159,7 +159,7 @@ func TestLifecyclePhaseKeepsReleasesForever(t *testing.T) {
 
 		check := NewOctopusLifecycleRetentionPolicyCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -197,7 +197,7 @@ func TestLifecyclePhaseKeepsFilesForever(t *testing.T) {
 
 		check := NewOctopusLifecycleRetentionPolicyCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_project_group_with_exclusive_environments_test.go b/internal/checks/organization/octopus_project_group_with_exclusive_environments_test.go
@@ -29,7 +29,7 @@ func TestProjectGroupsWithMutuallyExcluiveProjectLifecycles(t *testing.T) {
 
 		check := NewOctopusProjectGroupsWithExclusiveEnvironmentsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_project_specific_environment_check_test.go b/internal/checks/organization/octopus_project_specific_environment_check_test.go
@@ -29,7 +29,7 @@ func TestProjectSpecificEnvironmentsFromDefaultLifecycle(t *testing.T) {
 
 		check := NewOctopusProjectSpecificEnvironmentCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestProjectSpecificEnvironmentsFromCustomLifecycle(t *testing.T) {
 
 		check := NewOctopusProjectSpecificEnvironmentCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_project_too_many_steps_check_test.go b/internal/checks/organization/octopus_project_too_many_steps_check_test.go
@@ -29,7 +29,7 @@ func TestSmallDeploymentProcess(t *testing.T) {
 
 		check := NewOctopusProjectTooManyStepsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestComplexDeploymentProcess(t *testing.T) {
 
 		check := NewOctopusProjectTooManyStepsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_tenants_instead_of_tags_check_test.go b/internal/checks/organization/octopus_tenants_instead_of_tags_check_test.go
@@ -29,7 +29,7 @@ func TestDirectTenantReferences(t *testing.T) {
 
 		check := NewOctopusTenantsInsteadOfTagsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestTenantTagReferences(t *testing.T) {
 
 		check := NewOctopusTenantsInsteadOfTagsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_unhealthy_target_count_test.go b/internal/checks/organization/octopus_unhealthy_target_count_test.go
@@ -46,7 +46,7 @@ func TestUnhealthyTargets(t *testing.T) {
 
 		check := NewOctopusUnhealthyTargetCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_unused_projects_check_test.go b/internal/checks/organization/octopus_unused_projects_check_test.go
@@ -29,7 +29,7 @@ func TestUnusedProjects(t *testing.T) {
 
 		check := NewOctopusUnusedProjectsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_unused_targets_check_test.go b/internal/checks/organization/octopus_unused_targets_check_test.go
@@ -29,7 +29,7 @@ func TestUnusedTargetVars(t *testing.T) {
 
 		check := NewOctopusUnusedTargetsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/organization/octopus_unused_variables_check_test.go b/internal/checks/organization/octopus_unused_variables_check_test.go
@@ -29,7 +29,7 @@ func TestNoUnusedVars(t *testing.T) {
 
 		check := NewOctopusUnusedVariablesCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -62,7 +62,7 @@ func TestNoUnusedVarsInOneHundrenProjects(t *testing.T) {
 
 		check := NewOctopusUnusedVariablesCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -95,7 +95,7 @@ func TestUnusedVars(t *testing.T) {
 
 		check := NewOctopusUnusedVariablesCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/performance/octopus_deployment_queued_time_check_test.go b/internal/checks/performance/octopus_deployment_queued_time_check_test.go
@@ -1750,7 +1750,7 @@ func TestLongTaskQueue(t *testing.T) {
 	newSpaceClient, err := octoclient.CreateClient(server.URL, "Spaces-1", test.ApiKey)
 	check := NewOctopusDeploymentQueuedTimeCheck(newSpaceClient, &config.OctolintConfig{}, "http://test.app", "Spaces-1", checks.OctopusClientPermissiveErrorHandler{})
 
-	result, err := check.Execute()
+	result, err := check.Execute(2)
 
 	if err != nil {
 		t.Fatal("Check produced an error")

diff --git a/internal/checks/security/octopus_deployment_queued_by_admin_test.go b/internal/checks/security/octopus_deployment_queued_by_admin_test.go
@@ -128,7 +128,7 @@ func TestDeployedByAdmin(t *testing.T) {
 
 		check := NewOctopusDeploymentQueuedByAdminCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err
@@ -279,7 +279,7 @@ func TestDeployedByUser(t *testing.T) {
 
 		check := NewOctopusDeploymentQueuedByAdminCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/security/octopus_duplicated_git_creds_check_test.go b/internal/checks/security/octopus_duplicated_git_creds_check_test.go
@@ -38,7 +38,7 @@ func TestDuplicatedGitCreds(t *testing.T) {
 
 		check := NewOctopusDuplicatedGitCredentialsCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/security/octopus_insecure_feeds_check_test.go b/internal/checks/security/octopus_insecure_feeds_check_test.go
@@ -35,7 +35,7 @@ func TestInsecureFeeds(t *testing.T) {
 			&config.OctolintConfig{},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/security/octopus_insecure_k8s_check_test.go b/internal/checks/security/octopus_insecure_k8s_check_test.go
@@ -35,7 +35,7 @@ func TestInsecureK8s(t *testing.T) {
 			&config.OctolintConfig{},
 			checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err

diff --git a/internal/checks/security/octopus_perpetual_api_keys_check_test.go b/internal/checks/security/octopus_perpetual_api_keys_check_test.go
@@ -49,7 +49,7 @@ func TestPerpetualApiKeys(t *testing.T) {
 
 		check := NewOctopusPerpetualApiKeysCheck(newSpaceClient, &config.OctolintConfig{}, checks.OctopusClientPermissiveErrorHandler{})
 
-		result, err := check.Execute()
+		result, err := check.Execute(2)
 
 		if err != nil {
 			return err