Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh machine policies doc #2599

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

tleed5
Copy link
Contributor

@tleed5 tleed5 commented Dec 17, 2024

Refreshes the machine policies doc

Key changes

  • Added more details about each of the available configuration options
  • Restructured some of the sections to be grouped with related sections
  • Added new screenshots and updated existing ones

Recommend looking at these changes locally while reviewing, there is a bit too many changes to cover all in screenshots

@tleed5 tleed5 marked this pull request as ready for review December 18, 2024 01:12
Copy link
Contributor

@flin-8 flin-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe get Steve to skim through it for wording choices

Copy link
Contributor

@steve-fenton-octopus steve-fenton-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for inlining the include file.

@steve-fenton-octopus steve-fenton-octopus merged commit a8a0b64 into main Jan 10, 2025
4 checks passed
@steve-fenton-octopus steve-fenton-octopus deleted the tl/refresh-machine-policies branch January 10, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants