Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A light edit of deprecations. #2244

Merged
merged 3 commits into from
Apr 18, 2024
Merged

A light edit of deprecations. #2244

merged 3 commits into from
Apr 18, 2024

Conversation

steve-fenton-octopus
Copy link
Contributor

Mainly to simplify sentences and remove passive voice.

rain-on
rain-on approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@rain-on rain-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - not sure if the client vs. customer issue is a dealbreaker, but the new version felt "off" from a technical standpoint.

src/pages/docs/deprecations/index.md Outdated Show resolved Hide resolved
src/pages/docs/deprecations/index.md Outdated Show resolved Hide resolved
@steve-fenton-octopus steve-fenton-octopus merged commit 9c996ce into main Apr 18, 2024
4 checks passed
@steve-fenton-octopus steve-fenton-octopus deleted the sf/deprecations-light-edit branch April 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rain-on rain-on rain-on approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steve-fenton-octopus @rain-on