Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename target roles to target tags on the Deployment targets page #2238

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

david-wu-octopus
Copy link
Contributor

@david-wu-octopus david-wu-octopus commented Apr 17, 2024

Description

[sc-75742]

This PR renames target roles to target tags on the Deployment targets page.

Changes

Updated page

localhost_3000_docs_infrastructure_deployment-targets

New callout

Screenshot 2024-04-17 at 3 10 05 pm

@@ -1,12 +1,16 @@
[Getting Started - Machine Roles](https://www.youtube.com/watch?v=AU8TBEOI-0M)

Before you can deploy software to your deployment targets, you need to tag them with target roles. This ensures you deploy the right software to the right deployment targets. Typical target roles include:
:::div{.info}
**Target roles** are **target tags** from Octopus Deploy **2024.2** onwards. The functionality remains the same. This is only a name change to make our terminology clearer. No action is needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove no action is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

**Target roles** are **target tags** from Octopus Deploy **2024.2** onwards. The functionality remains the same. This is only a name change to make our terminology clearer. No action is needed.
:::

Before you can deploy software to your deployment targets, you need to associate them with target tags. This ensures you deploy the right software to the right deployment targets. Typical target tags include:

- web-server
- app-server
- db-server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a cluster-like tag name in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added product-cluster to the top of the list


Deployment targets can have more than one role, and more than one deployment target can have the same role, but every deployment target must have at least one role.
Deployment targets can have more than one target tag, and more than one deployment target can have the same target tag, but every deployment target must have at least one target tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think target tag can be just tag here, since we are specifically talking about targets in this sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think I went overboard on the be explicit about target tags guidance 😂

@steve-fenton-octopus
Copy link
Contributor

Hi @david-wu-octopus I've sent you a PR to update the modified date.

#2241

@david-wu-octopus david-wu-octopus merged commit f285c1a into main Apr 18, 2024
4 checks passed
@david-wu-octopus david-wu-octopus deleted the davidwu/update-deployment-targets-page branch April 18, 2024 04:21
@david-wu-octopus david-wu-octopus restored the davidwu/update-deployment-targets-page branch April 18, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants