-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added external feed trigger docs #2218
Conversation
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
Unlike the existing [Automatic Release Creation](/docs/projects/project-triggers/automatic-release-creation) feature, you can create multiple external feed triggers per channel. This can enable you to, for example, have your external container dependencies in a separate trigger to that used for your internal container dependencies. | ||
|
||
:::figure | ||
![Channel selection](/docs/projects/project-triggers/images/external-trigger-channel.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps changing to an image with an automatically deployed phase would be good here?
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
This pull request has been linked to: |
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
src/pages/docs/projects/project-triggers/external-feed-triggers.md
Outdated
Show resolved
Hide resolved
@MissedTheMark I have a PR to resolve your spelling woes here: |
…s-Dictionary Fixes spelling errors
Should we highlight in the doc intro that this feature is for Kubernetes? Maybe the first sentence could say something like, 'This feature enables pull-driven deployments for Kubernetes steps'. Should we have a history section in the doc? Should we explain how the feature works? Something like it creates a task every 3 minutes, etc. I believe the channel and source sections miss whys. I.e. what are the use cases for this? We can explain that you might want to test an interim version and don't want to promote it to production, in this case you can use this tag, or if it's a hothix, use this. The same is true for the source selection; we could say something like, 'If you have a 3rd party repo, you can monitor all the included packages to spot updates automatically). The paragraph above makes me think that we'll benefit from a new doc, something like 'triggers best practices' or 'triggers use cases'. We could show a few examples like
|
These are good points, I'll make some updates The second half of the message I've referenced in this card. Unsure if we'll do it as a separate PR or bring it in here too. |
To save you running the project locally, this is a rendered version of the new triggers page as at commit d13b9c2:
Changes to the Releases and Dependencies page
Before
After
Changes to the ARC page
Added this heading to the ARC page (now Built-in package repository triggers):
There are a few other changes included in the move from ARC to built in package repo triggers.
[sc-61201]
[sc-73064]