Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make Code Testable #697

Merged
merged 12 commits into from
Nov 10, 2023

Conversation

shubham-cmyk
Copy link
Member

No description provided.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Files Coverage Δ
controllers/redis_controller.go 0.00% <0.00%> (ø)
k8sutils/client.go 63.15% <88.88%> (+63.15%) ⬆️
k8sutils/status.go 0.00% <0.00%> (ø)
k8sutils/redis-sentinel.go 31.06% <0.00%> (-0.48%) ⬇️
k8sutils/secrets.go 0.00% <0.00%> (ø)
k8sutils/finalizer.go 3.12% <14.28%> (+3.12%) ⬆️
k8sutils/services.go 32.43% <0.00%> (-3.66%) ⬇️
k8sutils/redis.go 2.61% <0.00%> (-0.09%) ⬇️
k8sutils/poddisruption.go 0.00% <0.00%> (ø)
k8sutils/statefulset.go 27.13% <0.00%> (-0.94%) ⬇️

📢 Thoughts on this report? Let us know!

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@drivebyer drivebyer self-requested a review November 10, 2023 02:22
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk merged commit 9167791 into OT-CONTAINER-KIT:master Nov 10, 2023
17 of 19 checks passed
@shubham-cmyk shubham-cmyk deleted the client-test branch November 10, 2023 19:58
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* testing-client

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* client_test.go

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* push

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix Client

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix Dockerfile

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* try fixing lint

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix ci

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* ignoree

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* change location

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants