Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip-reconcile annotation still skipping reconcile even the value is false #1202

Merged

Conversation

husnialhamdani
Copy link
Contributor

@husnialhamdani husnialhamdani commented Jan 9, 2025

Description

skip-reconcile annotation still skipping reconcile even the value is false

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@husnialhamdani husnialhamdani changed the title fix: skip-reconcile annotation still skipping reconcile even the valu… fix: skip-reconcile annotation still skipping reconcile even the value is false Jan 9, 2025
…e is false

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (60ef5a2) to head (f0a0a85).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controllers/redis/redis_controller.go 0.00% 0 Missing and 1 partial ⚠️
...ontrollers/rediscluster/rediscluster_controller.go 0.00% 0 Missing and 1 partial ⚠️
...rs/redisreplication/redisreplication_controller.go 0.00% 0 Missing and 1 partial ⚠️
...trollers/redissentinel/redissentinel_controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   30.20%   29.66%   -0.55%     
==========================================
  Files          55       57       +2     
  Lines        6294     6601     +307     
==========================================
+ Hits         1901     1958      +57     
- Misses       4200     4453     +253     
+ Partials      193      190       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit b00f1df into OT-CONTAINER-KIT:master Jan 13, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants