Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary waits from e2e tests #1106

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

Nashluffy
Copy link
Contributor

Description

For all the tests I've changed, there are existing assertions that the cluster/sentinel/redis is ready, so the sleeps are unnecessary. From the looks of it, they predate the ready assertions.

Partial fix for #1104

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

It's very possible there's additional context I'm missing on why these sleeps are still in the codebase.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.03%. Comparing base (d121d86) to head (ec84176).
Report is 133 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   35.20%   44.03%   +8.83%     
==========================================
  Files          19       21       +2     
  Lines        3213     3431     +218     
==========================================
+ Hits         1131     1511     +380     
+ Misses       2015     1832     -183     
- Partials       67       88      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator

@Nashluffy Could you please rebase on the master branch

mluffman and others added 3 commits November 13, 2024 16:00
Signed-off-by: mluffman <mluffman@thoughtmachine.net>
Signed-off-by: mluffman <mluffman@thoughtmachine.net>
@drivebyer drivebyer changed the title fix: remove unnecessary waits from e2e tests test: remove unnecessary waits from e2e tests Nov 13, 2024
@drivebyer drivebyer merged commit 0eac383 into OT-CONTAINER-KIT:master Nov 13, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants