Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad indentation on redis standalone additional configs #1040

Conversation

dschaaff
Copy link
Contributor

@dschaaff dschaaff commented Aug 6, 2024

Description

The standalone redis template had the incorrect indentation for additionalRedisConfig. As a result any external configs passed through the helm chart were not added to the redis manifest and apply. A simple indentation fix is all that was needed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

It was incorrectly being nested under the redis exporter config key.

Signed-off-by: Daniel Schaaff <daniel@danielschaaff.com>
@dschaaff dschaaff force-pushed the fix-redis-standalone-helm-extra-config branch from a24d0c7 to 76e0cdb Compare August 6, 2024 01:04
@drivebyer drivebyer changed the title fix bad indentation on redis standalone additional configs fix: bad indentation on redis standalone additional configs Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (d121d86) to head (76e0cdb).
Report is 91 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1040       +/-   ##
===========================================
+ Coverage   35.20%   46.19%   +10.99%     
===========================================
  Files          19       20        +1     
  Lines        3213     2704      -509     
===========================================
+ Hits         1131     1249      +118     
+ Misses       2015     1380      -635     
- Partials       67       75        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator

Thank you for your contribution.

@drivebyer drivebyer merged commit 31c5dca into OT-CONTAINER-KIT:master Aug 6, 2024
28 of 30 checks passed
@drivebyer drivebyer added the bug Something isn't working label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants