-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated aws function #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shellcheck] reported by reviewdog 🐶
Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. SC2181
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 67 in 8799565
if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 72 in 8799565
AWS_ACCESS_KEY_ID=$(echo $role_output | jq -r '.Credentials.AccessKeyId') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 73 in 8799565
AWS_SECRET_ACCESS_KEY=$(echo $role_output | jq -r '.Credentials.SecretAccessKey') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 74 in 8799565
AWS_SESSION_TOKEN=$(echo $role_output | jq -r '.Credentials.SessionToken') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 86 in 8799565
aws_access_key=$(echo $aws_creds | sed "s/'/\"/g" | jq -r '.aws_access_key') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 87 in 8799565
aws_secret_access_key=$(echo $aws_creds | sed "s/'/\"/g" | jq -r '.aws_secret_access_key') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INSTANCE_NAME appears unused. Verify use (or export if used externally). SC2034
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 109 in 8799565
INSTANCE_NAME="$7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUILDX_ENABLE appears unused. Verify use (or export if used externally). SC2034
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 110 in 8799565
BUILDX_ENABLE="$8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shellcheck] reported by reviewdog 🐶
Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. SC2181
BP-BASE-SHELL-STEPS/aws-functions.sh
Line 130 in 8799565
if [ $? -ne 0 ]; then |
No description provided.