Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for patch 2024.03.1 #11363

Merged
merged 14 commits into from
Apr 15, 2024
Merged

Fixes for patch 2024.03.1 #11363

merged 14 commits into from
Apr 15, 2024

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Apr 14, 2024

Closes #11352
Closes #11353
Closes #11355
Closes #11337
Closes #11359

magnesj and others added 13 commits April 14, 2024 13:21
Always allocate result data for active cells in destination case. Make sure that active cells is used for both population of expression variables and filtering of data. Improved naming to make it clear that we always work with active cell data.
addStaticScalarResult will clear already computed data, causing calculations to be triggered once more
If not checking if data is available, data is read from file and appended to result vector.
…tersection

Size of the overlay is could become negative, and would overflow for small views.

Fixes #11334.
Well pipe radius would become HUGE_VAL due to off-by-one error.
The assert could only happen on model with a single cell.

Fixes #11310.
Equal grid size is required if there is more than one grid case in the expression. If a cell filter view is active, the visibility is based on one view and reused for all other grid models, and requires equal grid size.
@magnesj magnesj requested a review from kriben April 15, 2024 07:09
@magnesj magnesj marked this pull request as ready for review April 15, 2024 07:09
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it!

@magnesj magnesj merged commit 62e497f into main Apr 15, 2024
19 checks passed
@magnesj magnesj deleted the patch-2024.03 branch April 15, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants