Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #10938

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix build issues #10938

merged 2 commits into from
Dec 11, 2023

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Dec 11, 2023

Closes #10936
Closes #10937

Several operations was attached to the POST_BUILD custom command of the ResInsight target. The number of characters in this command exceeded the limit on Windows, and error message "line too long" was displayed on GitHub actions.

Suggested solution to copy files into build folder
- add new target ResInsightDummyTarget used to find full path to build folder
- add new target PreBuildFileCopy for file copy
- add all copy operations as a list of cmake commands on PreBuildFileCopy
Previous OpenVds version was removed from server, update to latest available 3.2 version
@magnesj magnesj requested review from kriben and jonjenssen December 11, 2023 07:49
@magnesj magnesj marked this pull request as ready for review December 11, 2023 07:49
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magnesj magnesj merged commit b3865d2 into dev Dec 11, 2023
17 checks passed
@magnesj magnesj deleted the fix-build-issues branch December 11, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using POST_BUILD to copy files to build folder Update OpenVDS library
2 participants