Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for release #10921

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Adjustments for release #10921

merged 6 commits into from
Dec 11, 2023

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Dec 7, 2023

Closes #10920
Closes #10911
Closes #10922
Closes #10923

@magnesj magnesj force-pushed the adjustments-for-release branch 2 times, most recently from c320fd9 to d90c650 Compare December 8, 2023 12:40
@magnesj magnesj force-pushed the adjustments-for-release branch from d90c650 to aaa30d2 Compare December 11, 2023 10:04
Do not try to create ESMRY file if there are no time steps in the summary data
Do not try to read "TIME" record if no time steps are present
@magnesj magnesj force-pushed the adjustments-for-release branch from aaa30d2 to d89602d Compare December 11, 2023 10:22
@magnesj magnesj force-pushed the adjustments-for-release branch from 94c5fb2 to 72dd0c7 Compare December 11, 2023 10:29
@magnesj magnesj marked this pull request as ready for review December 11, 2023 10:43
@magnesj magnesj requested a review from kriben December 11, 2023 10:43
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally I would prefer references to the issues fixed in the indivdual commits (not the merge commit).

@magnesj magnesj merged commit b34c6b9 into dev Dec 11, 2023
17 checks passed
@magnesj magnesj deleted the adjustments-for-release branch December 11, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants