Attempt to handle running Char in incremental mode #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
===========================================
+ Coverage 98.94% 98.98% +0.04%
===========================================
Files 14 14
Lines 3498 3544 +46
===========================================
+ Hits 3461 3508 +47
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
chrisknoll
reviewed
Jan 17, 2025
Comment on lines
+29
to
+35
| # Handle cleaning of incremental folders/files | ||
| if (isTRUE(executionSettings$incremental)) { | ||
| Characterization::cleanIncremental(workFolder) | ||
| } else { | ||
| Characterization::cleanNonIncremental(workFolder) | ||
| } | ||
|
|
There was a problem hiding this comment.
@jreps , could you provide feedback if this is the appropriate use of cleanIncremental vs. cleanNonIncremental?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to use the Characterization package functions to properly handle when running in incremental mode.