update rpkg commands to print to correct stream on execution

Signed-off-by: Kushal Harish Naidu <kushal.harish.naidu@ericsson.com>

pkg/cli/commands/rpkg/approve/command.go

@@ -92,7 +92,7 @@ func (r *runner) runE(_ *cobra.Command, args []string) error {
 			messages = append(messages, err.Error())
 			fmt.Fprintf(r.Command.ErrOrStderr(), "%s failed (%s)\n", name, err)
 		} else {
-			fmt.Fprintf(r.Command.OutOrStderr(), "%s approved\n", name)
+			fmt.Fprintf(r.Command.OutOrStdout(), "%s approved\n", name)
 		}
 	}
 

pkg/cli/commands/rpkg/get/command.go

@@ -227,7 +227,7 @@ func (r *runner) runE(cmd *cobra.Command, args []string) error {
 	if err := w.Flush(); err != nil {
 		return errors.E(op, err)
 	}
-
+	fmt.Fprintf(cmd.OutOrStdout(), "Package revision deleted successfully\n")
 	return nil
 }
 

pkg/cli/commands/rpkg/propose/command.go

@@ -109,7 +109,7 @@ func (r *runner) runE(_ *cobra.Command, args []string) error {
 			messages = append(messages, err.Error())
 			fmt.Fprintf(r.Command.ErrOrStderr(), "%s failed (%s)\n", name, err)
 		} else {
-			fmt.Fprintf(r.Command.OutOrStderr(), "%s proposed\n", name)
+			fmt.Fprintf(r.Command.OutOrStdout(), "%s proposed\n", name)
 		}
 	}
 

pkg/cli/commands/rpkg/proposedelete/command.go

@@ -109,7 +109,7 @@ func (r *runner) runE(_ *cobra.Command, args []string) error {
 			messages = append(messages, err.Error())
 			fmt.Fprintf(r.Command.ErrOrStderr(), "%s failed (%s)\n", name, err)
 		} else {
-			fmt.Fprintf(r.Command.OutOrStderr(), "%s proposed for deletion\n", name)
+			fmt.Fprintf(r.Command.OutOrStdout(), "%s proposed for deletion\n", name)
 		}
 	}
 

pkg/cli/commands/rpkg/pull/command.go

@@ -16,6 +16,7 @@ package pull
 
 import (
 	"context"
+	"fmt"
 	"io"
 	"os"
 	"path/filepath"
@@ -96,7 +97,7 @@ func (r *runner) preRunE(_ *cobra.Command, _ []string) error {
 	return nil
 }
 
-func (r *runner) runE(_ *cobra.Command, args []string) error {
+func (r *runner) runE(cmd *cobra.Command, args []string) error {
 	const op errors.Op = command + ".runE"
 
 	if len(args) == 0 {
@@ -126,6 +127,7 @@ func (r *runner) runE(_ *cobra.Command, args []string) error {
 			return errors.E(op, err)
 		}
 	}
+	fmt.Fprintf(cmd.OutOrStdout(), "Package: %s pulled successfully\n", packageName)
 	return nil
 }
 

pkg/cli/commands/rpkg/push/command.go

@@ -163,6 +163,7 @@ func (r *runner) runE(cmd *cobra.Command, args []string) error {
 			r.printFnResult(result, printOpt)
 		}
 	}
+	fmt.Fprintf(cmd.OutOrStdout(), "Package: %s pushed successfully\n", packageName)
 	return nil
 }
 

pkg/cli/commands/rpkg/reject/command.go

@@ -112,15 +112,15 @@ func (r *runner) runE(_ *cobra.Command, args []string) error {
 				messages = append(messages, err.Error())
 				fmt.Fprintf(r.Command.ErrOrStderr(), "%s failed (%s)\n", name, err)
 			} else {
-				fmt.Fprintf(r.Command.OutOrStderr(), "%s rejected\n", name)
+				fmt.Fprintf(r.Command.OutOrStdout(), "%s rejected\n", name)
 			}
 		case v1alpha1.PackageRevisionLifecycleDeletionProposed:
 			pr.Spec.Lifecycle = v1alpha1.PackageRevisionLifecyclePublished
 			if err := r.porchClient.Update(r.ctx, pr); err != nil {
 				messages = append(messages, err.Error())
 				fmt.Fprintf(r.Command.ErrOrStderr(), "%s failed (%s)\n", name, err)
 			} else {
-				fmt.Fprintf(r.Command.OutOrStderr(), "%s no longer proposed for deletion\n", name)
+				fmt.Fprintf(r.Command.OutOrStdout(), "%s no longer proposed for deletion\n", name)
 			}
 		default:
 			msg := fmt.Sprintf("cannot reject %s with lifecycle '%s'", name, pr.Spec.Lifecycle)