Issue #828 - few more golangci-lint fixes

nephio-project/nephio#828
Nordix · Jan 16, 2025 · 0d4f9fe · 0d4f9fe
1 parent 35209be
commit 0d4f9fe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/registry/porch/strategy.go b/pkg/registry/porch/strategy.go
@@ -120,7 +120,7 @@ var _ SimpleRESTCreateStrategy = packageRevisionStrategy{}
 // before the object is persisted.  This method should not mutate the
 // object.
 func (s packageRevisionStrategy) Validate(ctx context.Context, runtimeObj runtime.Object) field.ErrorList {
-	ctx, span := tracer.Start(ctx, "packageRevisionStrategy::Validate", trace.WithAttributes())
+	_, span := tracer.Start(ctx, "packageRevisionStrategy::Validate", trace.WithAttributes())
 	defer span.End()
 
 	allErrs := field.ErrorList{}

diff --git a/pkg/repository/util.go b/pkg/repository/util.go
@@ -71,7 +71,7 @@ func toApiConditionStatus(s kptfile.ConditionStatus) api.ConditionStatus {
 }
 
 func NextRevisionNumber(ctx context.Context, revs []string) (string, error) {
-	ctx, span := tracer.Start(ctx, "draft.go::NextRevisionNumber", trace.WithAttributes())
+	_, span := tracer.Start(ctx, "util.go::NextRevisionNumber", trace.WithAttributes())
 	defer span.End()
 
 	// Computes the next revision number as the latest revision number + 1.

diff --git a/pkg/task/builtin.go b/pkg/task/builtin.go
@@ -48,7 +48,7 @@ func newPackageContextGeneratorMutation(packageConfig *builtins.PackageConfig) (
 var _ mutation = &builtinEvalMutation{}
 
 func (m *builtinEvalMutation) apply(ctx context.Context, resources repository.PackageResources) (repository.PackageResources, *api.TaskResult, error) {
-	ctx, span := tracer.Start(ctx, "builtinEvalMutation::Apply", trace.WithAttributes())
+	_, span := tracer.Start(ctx, "builtinEvalMutation::Apply", trace.WithAttributes())
 	defer span.End()
 
 	ff := &runtimeutil.FunctionFilter{