Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: docs fix spelling issues #6093

Closed
wants to merge 4 commits into from
Closed

chore: docs fix spelling issues #6093

wants to merge 4 commits into from

Conversation

sky-coderay
Copy link

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f12ccb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:41am

schaable
schaable reviewed Dec 30, 2024
View reviewed changes
docs/src/content/hardhat-runner/docs/advanced/flattening.md Outdated
@@ -53,7 +53,7 @@ npx hardhat flatten contracts/Foo.sol contracts/Bar.sol

But if `Bar.sol` is a dependency of `Foo.sol`, then the result will be the same as in the previous example.

As explained in the previous section, you can redirect the output to some file:
As explained in the previous section, you can redirect the output to some a file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a typo

schaable
schaable requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@schaable schaable added type:docs Documentation-related issue no changeset needed This PR doesn't require a changeset labels Dec 30, 2024
@sky-coderay
Copy link
Author

@schaable thanks , done !

Happy New Year !

@schaable
Copy link
Member

schaable commented Jan 1, 2025

@schaable thanks , done !

Happy New Year !

The change in docs/src/content/hardhat-runner/docs/advanced/flattening.md is still incorrect. It should read "As explained in the previous section, you can redirect the output to a file:"

@sky-coderay
Copy link
Author

@schaable done

@alcuadrado alcuadrado closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaable schaable schaable requested changes

Assignees

@kanej kanej

Labels
no changeset needed This PR doesn't require a changeset status:triaging type:docs Documentation-related issue
Projects
Hardhat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sky-coderay @schaable @kanej @alcuadrado