fix: exit check task with exit code 1 when solhint raises errors

[galargh]

• Because this PR includes a bug fix, relevant tests have been included.
• Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• I didn't do anything of this.

---

Resolves #5057

This PR modifies the hardhat-solhint plugin.

It changes the check task behaviour. After the changes, when solhint reports any errors (note, this does not apply to warnings), the task exists with error code 1.

The updated behaviour is in line with how solhint behaves as a standalone CLI tool.

Please note that this is, currently, a breaking change since it's modifying solhint plugin/check task behaviour. I will update the changesets and mark the PR as "ready for review", once we align on the open questions I outline below.

Open Questions

1. Should we update solhint to the most recent version v5.0.2? Yes
2. Should we control the newly added behaviour via configuration? If so, we could also support failing the check task when a threshold of warnings is crossed. In solhint, this is controlled via command line options. No (not yet, at least)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2024 2:30pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 570f79d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@nomiclabs/hardhat-solhint	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kanej]

I think we bump to version v5.0.2. We are taking the hit of a major update due to the breaking cli behaviour change; so lets move to the latest version at the same time.

I think we leave off of replicating the cli behaviour around warnings. This can be added later if there is demand.

[kanej]

This PR is looking good. I left two requests:

1. splitting the changeset into two parts
2. updating the exit technique if there are errors

[kanej]

LGTM!

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.