Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf2htmlEX: mark as broken #46369

Merged
merged 1 commit into from
Sep 9, 2018
+1 −0
Merged

pdf2htmlEX: mark as broken #46369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/tools/typesetting/pdf2htmlEX/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ stdenv.mkDerivation rec {
license = licenses.gpl3Plus;
maintainers = [ maintainers.taktoa ];
platforms = with platforms; linux;
broken = true; # 2018-09-08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the information from the issue description (link to upstream issue and AUR commit, no longer maintained) as a comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honest question: isn't it sufficient to write it into the commit message (which is what I usually do) or do you prefer the information as code comment as well?:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the information as a comment is vastly more useful. When somebody in the future wonders "why is this broken? can I maybe fix this?" they can just check the comment, read the explanation and check the linked sources. When the information is hidden in a comment message he might be able to find that with git-blame, but only if the code hasn't been moved around or heavily refactored since then.

I'm not exactly happy that @Mic92 merged this already, but the info in the commit message will do for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlikely to happen for broken status, because the next change will hopefully remove the broken attribute again.

};
}