workflows: lock Ubuntu and macOS runners and update Ubuntu runner #368442
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
nix-owners
bot
requested review from
azuwis,
infinisil,
LeSuisse,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Agree with this direction. Better than having it fault in over the next days. I'm not planning on merging this myself; I feel better having @infinisil or another watcher of the CIs merge.
trueNAHO
changed the title
trueNAHO
changed the title
Lock the Ubuntu runner to ubuntu-22.04 to avoid accidental updates [1] and increase reproducibility. [1]: actions/runner-images#10636
trueNAHO
force-pushed
the
workflows-lock-and-update-runner
branch
from
a744e50 to
2533b63
Compare
drupol
approved these changes
Dec 29, 2024
wegank
added
the
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock the Ubuntu and macOS runners to avoid accidental updates 1 and increase reproduciblity. Then, update the Ubuntu runner to what
ubuntu-latestwill soon point to 1, which hopefully causes no problems on our end.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.