-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,feat!: (1) New events and tx resp abstractions. (2) Cater tests to devnet #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor: move types to pytypes. export all types from nibiru.ptypes module. - fix: Find a gas config that works better for the E2E tests. - fix: Get most of the perp tests passing again.
… TM endpoint. Add docstring for 'Network' class.
- (2) test(dex): Remove uusdc as it does not exist on chain
Unique-Divine
requested review from
matthiasmatt,
NibiruHeisenberg and
onikonychev
as code owners
December 9, 2022 07:42
Unique-Divine
added
type: enhancement
New feature or request
type: test
Adding missing tests or improve existing tests
epic
Large task that is a parent to several issues/tasks
labels
Dec 9, 2022
Unique-Divine
changed the title
test,refactor!: (1) New events and tx resp abstractions. (2) Cater tests to devnet
test,feat!: (1) New events and tx resp abstractions. (2) Cater tests to devnet
Dec 9, 2022
Unique-Divine
commented
Dec 9, 2022
Comment on lines
+124
to
+126
output: dict = MessageToDict(proto_output).get("pools") | ||
if output is None: | ||
output = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a KeyError that gets raised if no pools come back in the query
onikonychev
reviewed
Dec 9, 2022
onikonychev
reviewed
Dec 9, 2022
onikonychev
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
epic
Large task that is a parent to several issues/tasks
type: enhancement
New feature or request
type: test
Adding missing tests or improve existing tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pytest-order
to control the order of tests and break them into more manageable chunksis_insecure
propertysdk_val
orsdk_oracle
oversdk_agent
so that less transfers are required.tests.raises
function that has better UX thanpytest.raises
. See perp_test.py or dex_test.py for some examples.Tests on the
dex
andperp
module are more forgiving in that they don't depend as much on the initial state.dex
tests will fail, and the error messages will be super informative for debugging.Other notable changes
Pro-tip - Favor
BaseException
It's better to use
BaseException
thanException
if you're looking for a generic error message type because there are several built-in errors that don't count asException
, but everything counts asBaseException
.