Skip to content

Commit

Permalink
henrybetts#18 Revert adding privacy manifest, instead add to target i…
Browse files Browse the repository at this point in the history
…n swift
  • Loading branch information
SoylentGraham committed Nov 9, 2024
1 parent bc03b62 commit 71dbf76
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 4 additions & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ let package = Package(
),
.target(
name: "DawnNative",
dependencies: ["DawnFramework","WebGPU", "CDawnNative"]
dependencies: ["DawnFramework","WebGPU", "CDawnNative"],
resources: [
.copy("PrivacyInfo.xcprivacy")
]
),

.executableTarget(
Expand Down
5 changes: 0 additions & 5 deletions Sources/DawnNative/CreateXCFramework.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ MACOS_LIBRARY_PATH="${RELEASE_ROOT}/lib/libwebgpu_dawn.dylib"
MACOS_HEADER_PATH="${RELEASE_ROOT}/include"
DAWN_JSON_PATH="${RELEASE_ROOT}/dawn.json"

# apple require dawn sdk to provide a privacy manifest to submit to the store, as abseil is on their
# bad-privacy list
PRIVACY_INFO_PATH="${RELEASE_ROOT}/PrivacyInfo.xcprivacy"

# xcodebuild fails if any contents inside already exist, so clean it out
# ||true will continue (not exit 1) if the path doesnt exist
rm -r ${OUTPUT_PATH} || true
Expand All @@ -30,4 +26,3 @@ xcodebuild -create-xcframework \

# we cannot include arbritary files into an xcframework via normal means, but we can sneak them into the output folder
cp ${DAWN_JSON_PATH} ${OUTPUT_PATH}
cp ${PRIVACY_INFO_PATH} ${OUTPUT_PATH}

0 comments on commit 71dbf76

Please sign in to comment.