add to version tag to header on producer side #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunjeet
reviewed
Nov 8, 2023
| /** | ||
| * A header tag indicating which version is this snapshot produce to. | ||
| */ | ||
| String HEADER_TAG_PRODUCER_TO_VERSION = "hollow.producer.to.version"; |
There was a problem hiding this comment.
nit: name hollow.blob.to.version so it is more clear that this is the one in the blob (differentiating the one in metadata)
| @@ -388,6 +388,7 @@ long runCycle( | |||
| } else { | |||
| writeEngine.getHeaderTags().remove(HollowStateEngine.HEADER_TAG_SCHEMA_CHANGE); | |||
| } | |||
| writeEngine.addHeaderTag(HollowStateEngine.HEADER_TAG_PRODUCER_TO_VERSION, String.valueOf(toVersion)); | |||
There was a problem hiding this comment.
workeatsleep
force-pushed
the
producer-tag-version
branch
from
45962c2 to
f51e5f1
Compare
workeatsleep
force-pushed
the
producer-tag-version
branch
from
f51e5f1 to
4fe8fc4
Compare
Sunjeet
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a tag in header to imply the version