-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing stuff to accomondate the new DF3D API #13
Open
sibocw
wants to merge
6
commits into
master
Choose a base branch
from
new-df3d
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trickiest changes:
|
Works on all data in the DF3D paper except
|
This was referenced Oct 30, 2022
Copying potential next users: @jasper-tms @jonasfbraun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this addresses probably most of the incompatibilities between df3dpp and the new df3d API.
Exactly what I did / extent of testing: I tried to run Florian's behavior data processing on the data used for the DF3D paper. The DF3D outputs were regenerated in February using the new DF3D API. (I believe --- all output files that begin with
df3d_result_*.pkl
are generated with the new version, right?) The df3dpp package is also installed with separate (new)nely-df3d
andnely-pyba
packages. It seems to be working now, at least to me:Can the next user review the changes, and if everything looks good, merge please?