Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(android): Fixes crash on sdk27+ devices when saving to gallery #237

Closed
wants to merge 2 commits into from

Conversation

AdamAtri
Copy link

@AdamAtri AdamAtri commented Jan 20, 2020

PR Checklist

What is the current behavior?

On android devices running 27+ the app crashes when saving to the gallery.
This is caused by the creation of the picturePath. On 27+ devices the "Camera" directory is not created in the DCIM dir.

What is the new behavior?

The new code creates the 'Camera' directory if it does not exist.
Then verifies that there is a file at the expected location

Fixes/Implements/Closes #[225, 236].
BREAKING CHANGES: none
Migration steps: none

@cla-bot
Copy link

cla-bot bot commented Jan 20, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @AdamAtri.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@AdamAtri
Copy link
Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 20, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @AdamAtri.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Jan 20, 2020

The cla-bot has been summoned, and re-checked this pull request!

Refactor variable names to be more reflective of intention
@cla-bot
Copy link

cla-bot bot commented Jan 21, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @AdamAtri.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@AdamAtri
Copy link
Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 22, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @AdamAtri.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Jan 22, 2020

The cla-bot has been summoned, and re-checked this pull request!

@AdamAtri
Copy link
Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 24, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @AdamAtri.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Jan 24, 2020

The cla-bot has been summoned, and re-checked this pull request!

@AdamAtri
Copy link
Author

AdamAtri commented Jan 24, 2020

I have signed the cla 3 times
and the Travis CLI failures are yours ---> Cannot read property 'SAUCE_USER' of undefined

@AdamAtri AdamAtri closed this Jan 29, 2020
@luke-hawk
Copy link

Hey @AdamAtri – did you give up on this PR?😄 ...I also need a fix for #236 and #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants