-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(android): Fixes crash on sdk27+ devices when saving to gallery #237
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
The cla-bot has been summoned, and re-checked this pull request! |
Refactor variable names to be more reflective of intention
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
The cla-bot has been summoned, and re-checked this pull request! |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
The cla-bot has been summoned, and re-checked this pull request! |
I have signed the cla 3 times |
PR Checklist
What is the current behavior?
On android devices running 27+ the app crashes when saving to the gallery.
This is caused by the creation of the
picturePath
. On 27+ devices the "Camera" directory is not created in the DCIM dir.What is the new behavior?
The new code creates the 'Camera' directory if it does not exist.
Then verifies that there is a file at the expected location
Fixes/Implements/Closes #[225, 236].
BREAKING CHANGES: none
Migration steps: none