[WIP] replace int_div_ceil with std::cuda::ceil #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtryagain
requested review from
sleeepyjack and
PointKernel
as code owners
|
/ok to test |
PointKernel
added
the
type: improvement
|
@willtryagain Thank you for your contribution! The CI test failure is caused by an issue with CCCL (https://godbolt.org/z/94nYnvqMW), which may take some time to resolve. Could you please keep the PR open while we backlog it for now? We’ll handle the rest once |
|
/ok to test |
|
Hello @PointKernel , can you pleas tell if the check is failing because of problem in my code? or is it still |
Thank you for following up. It's still the CCCL issue. We'll revisit this once the upstream issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #631
Need assistance to add tests