Add BaseFedJob layer #3098
Draft
Add BaseFedJob layer #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerroth
reviewed
Dec 10, 2024
| @@ -335,10 +335,10 @@ | |||
| "from src.lit_net import LitNet\n", | |||
| "\n", | |||
| "from nvflare.app_common.workflows.fedavg import FedAvg\n", | |||
| "from nvflare.app_opt.pt.job_config.base_fed_job import BaseFedJob\n", | |||
| "from nvflare.app_opt.pt.job_config.base_fed_job import PTBaseFedJob\n", | |||
There was a problem hiding this comment.
So, are there PTFedJob and TFFedJobs as well? Maybe we can skip the "Base" in the name in these training framework specific job classes.
There was a problem hiding this comment.
We currently don't have PTFedJob/TFFedJobs. We could remove the "Base" in these names, would this class naming still make sense?
FedJob -> BaseFedJob -> PTFedJob
There was a problem hiding this comment.
Another proposal: Does this: PTJob -> CommonJob -> FedJob make sense?
Maybe we don’t need to make the names suggest the parent class they inherit from.
SYangster
force-pushed
the
base_fed_job
branch
from
91a0bea to
2a8826f
Compare
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add framework agnostic BaseFedJob layer, rename current classes to PTBaseFedJob and TFBaseFedJob
Types of changes
./runtest.sh.