Cross platform and proplib2.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed some things when copying changes into this repository. This commit fixes that.
also fix a typo in src/CMakeLists
This lets the template project successfully configure with CMake, which will be helpful for catching problems in the future.
This complicates CI
Add parseboolean function, remove dead code, and generalize printlabel
…rm-And-PropLib2.0 # Conflicts: # .gitignore # LICENSE.md # README.md
Mainly const-correctness
Replaced by STL equivalents
Also re-arrange an equation for `k` to make it fit on one line
These test data cases will not be distributed in the repository, but will be preserved in Git history prior to this commit and referenced in the upcoming v1.1 release notes
Add derivative_flag boolean to control function flow in Airy. Where the old `derivative` was used as an index, replace with `derivative_idx` which is more clear.
aromanielloNTIA
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
I merged in the more recent template changes, up to v1.0 of the template. I also made substantial additions and modifications to the Doxygen content, and implemented lots of const correctness. I replaced usage of the pow(x, THIRD) with std::cbrt(x). I also made some style changes, formatted all files with clang-format, and updated the version number to 1.1. Looks good! We will stage v1.1 release on dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.