Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FunctionData Printing #377

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Add FunctionData Printing #377

merged 3 commits into from
Jun 14, 2024

Conversation

GabrielKS
Copy link
Contributor

@GabrielKS GabrielKS commented Jun 11, 2024

I implemented some more human-friendly printing of the various FunctionData:
Screenshot 2024-06-11 at 4 04 51 PM

These could be useful when I do the same thing for the PSY cost structs (NREL-Sienna/PowerSystems.jl#1048).

Also fixed a typo in existing printing test code.

@GabrielKS GabrielKS requested review from daniel-thom and jd-lara June 11, 2024 22:09
@GabrielKS GabrielKS self-assigned this Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7fe2da2) to head (5c19680).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   77.16%   77.53%   +0.36%     
==========================================
  Files          66       66              
  Lines        5072     5092      +20     
==========================================
+ Hits         3914     3948      +34     
+ Misses       1158     1144      -14     
Flag Coverage Δ
unittests 77.53% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/function_data.jl 99.40% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@GabrielKS
Copy link
Contributor Author

GabrielKS commented Jun 12, 2024

Above formats are unchanged, added a third format that is human-readable but less verbose, for use where FunctionData are nested within other types that will convey that information (see e.g. NREL-Sienna/PowerSystems.jl#1125):
Screenshot 2024-06-12 at 2 24 53 PM

@GabrielKS
Copy link
Contributor Author

Re-requesting review for this ^ compact addition

@GabrielKS GabrielKS requested a review from kdayday June 14, 2024 19:12
Copy link
Contributor

@kdayday kdayday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compact looks nice

@GabrielKS GabrielKS merged commit c6f8c35 into main Jun 14, 2024
6 of 9 checks passed
@jd-lara jd-lara deleted the gks/add_function_data_printing branch June 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants