-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable Cost Refactor Part 2: PowerSimulations #332
Conversation
The group of four PRs this is a part of: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 79.99% 80.09% +0.10%
==========================================
Files 54 54
Lines 4319 4336 +17
==========================================
+ Hits 3455 3473 +18
+ Misses 864 863 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Alias instead of declaring the NamedTuple everywhere.
The second part of a significant refactor of Sienna cost data structures (part 1 is here). The main focus here is to bring PowerSimulations.jl up to date with the elimination of
VariableCost
in favor ofFunctionData
. That entails these changes in InfrastructureSystems:PiecewiseLinearPointData
useNamedTuples
so it's even harder to mix up x and yFunctionData
in other containers, like the ones in PowerSimulationsOn the latter point — does this functionality belong in PowerSimulations?
Tests pass: