Variable Cost Refactor Part 1: Function Data #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files `function_data.jl` and `test_function_data.jl` are copied from https://github.com/NREL-Sienna/PowerSystems.jl/tree/4a5375b9db694c1d64de0bec87234008d0c27640; see history there.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 79.57% 80.04% +0.47%
==========================================
Files 53 54 +1
Lines 4244 4315 +71
==========================================
+ Hits 3377 3454 +77
+ Misses 867 861 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
reviewed
Feb 22, 2024
| function transform_array_for_hdf( | ||
| data::SortedDict{Dates.DateTime, Vector{PiecewiseLinearPointData}}, | ||
| ) | ||
| quad_cost = hcat([get_points.(v) for v in values(data)]...) |
There was a problem hiding this comment.
Why is this called quad_cost for a PWL data? I see that the name is prior to this PR but it seems incorrect.
There was a problem hiding this comment.
It does seem incorrect. I'll change it
jd-lara
reviewed
Feb 22, 2024
| @@ -481,7 +515,10 @@ function transform_array_for_hdf(data::SortedDict{Dates.DateTime, Vector{PWL}}) | |||
| return t_quad_cost | |||
| end | |||
|
|
|||
| function transform_array_for_hdf(data::Vector{PWL}) | |||
| # TODO: old code here does not properly handle data with different numbers of points | |||
There was a problem hiding this comment.
This is ok. It was meant like that for proper storage in the HDF5 file
jd-lara
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of a significant refactor of Sienna cost data structures. See NREL-Sienna/PowerSystems.jl#1056 for more details. This PR consists of a new type
FunctionData, a new set of concrete subtype structs to represent various functions, and the necessary refactoring to use them rather thanIS.PWLand such in other InfrastructureSystems data structures. I also performed some minor code deduplication.IS, PSY, and PSB tests pass when using the appropriate branches of each plus PowerSystemsTestData:
