Fix reading of 2d time series data in test code #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function, which is only used in tests, was not handling time series data with multiple dimensions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 53 53
Lines 4240 4240
=======================================
Hits 3377 3377
Misses 863 863
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function, which is only used in tests, was not handling time series data with multiple dimensions.
This is a very old bug. It was triggered by the addition of supplemental attributes and outages to PowerSystem.jl. Tests for those features started using a system with 2-dimensional time series data. That code worked when in-memory time series data used, which happens in PowerSystemCaseBuilder when you set build_system(force_build=true).