Add subsystem interfaces #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-thom
commented
Feb 1, 2024
| @@ -79,7 +79,7 @@ Remove a component from a subsystem. | |||
|
|
|||
| Throws ArgumentError if the subsystem name or component is not stored. | |||
| """ | |||
| function remove_subsystem_component!( | |||
| function remove_component_from_subsystem!( | |||
There was a problem hiding this comment.
This should be symmetric with add_component_to_subsystem!.
daniel-thom
commented
Feb 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 79.56% 79.59% +0.03%
==========================================
Files 53 53
Lines 4218 4230 +12
==========================================
+ Hits 3356 3367 +11
- Misses 862 863 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
reviewed
Feb 6, 2024
| """ | ||
| Return true if the component is assigned to any subsystems. | ||
| """ | ||
| function is_assigned_to_subsystem( |
There was a problem hiding this comment.
Suggested change
| function is_assigned_to_subsystem( | |
| function is_assigned_to_a_subsystem( |
or
Suggested change
| function is_assigned_to_subsystem( | |
| function is_assigned_subsystems( |
Otherwise it could be confused with the query to wether something is attach to a specific subsystem
jd-lara
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.