Handle Relative Filepath #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceftanveer
commented
Jan 15, 2025
canflood/model/modcom.py
Outdated
| base_dir = os.path.dirname(os.path.dirname(__file__)) | ||
| parent_dir = os.path.dirname(base_dir) | ||
| fp = os.path.join(parent_dir, fp) | ||
| fp = os.path.join(self.cf_dir, fp) |
There was a problem hiding this comment.
@cefect leveraged self.cf_dir to get base directory path and joined it with filepath.
ceftanveer
commented
Jan 15, 2025
canflood/model/modcom.py
Outdated
| @@ -2106,6 +2104,8 @@ def _par_hndl_chk(self, | |||
| assert isinstance(pval, str), '%s.%s expected a filepath '%(sect, varnm) | |||
| if pval == '': | |||
| raise Error('must provided a valid \'%s.%s\' filepath'%(sect, varnm)) | |||
| if not os.path.exists(pval): | |||
| pval = os.path.join(self.cf_dir,pval) | |||
There was a problem hiding this comment.
@cefect here checking if the path is not valid then try to join it with base directory. even after this there is an assert statement so it will ensure the created path is valid. Adding this logic is producing correct paths and not showing errors in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #104
-updated all the hardcoded paths in control files to relative paths.
-Added logic to read relative path, this will now work in all the environments, since its not dependent on absolute paths.
-After adding this logic, Errors related to relative paths are not seen in tests.