Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Condition and Family Module Drafts #54

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

awarkow
Copy link
Collaborator

@awarkow awarkow commented Sep 20, 2024

Motivation

We need module documentation for family and condition

Approach

Starts a draft for each of these pages

@awarkow awarkow requested a review from calkinsh September 20, 2024 11:56
@awarkow awarkow self-assigned this Sep 20, 2024
@awarkow awarkow added the documentation Improvements or additions to documentation label Sep 20, 2024
@github-actions github-actions bot temporarily deployed to pull request September 20, 2024 12:00 Inactive
Copy link

github-actions bot commented Sep 20, 2024

🚀 IG Site Preview Deployed

Latest commit: f790be8

View deployment

Copy link
Member

@allisonheath allisonheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

input/pagecontent/module_family.md Show resolved Hide resolved



This distinction is similar to those in OMOP and FHIR, though it does not map precisely. Critically in OMOP and FHIR, Condition_occurrence and Condition are ALWAYS a positive assertion (though they may be wrong). “Assertions of history of disease” are observations in OMOP, eg, ICD9CM V-codes like “Personal history of malignant neoplasm of breast” go in Observation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if calling it "Condition Module" is going to make people assume we're using the FHIR Condition resource under the hood? And that this piece is too buried in the versus being a bit up front that it's actually an Observation and/or that we're talking more generically about it versus the specific Condition resource?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thought on this: The "Condition Module" should ALSO have a condition profile IMO. The "Condition Summary" resource would help round this out. I think we want people looking for "Conditions" or looking for "Condition Resources" to come here to understand what we are doing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge the current state of these changes but open a ticket to add updates @RobertJCarroll is describing here.

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 15:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 18:03 Inactive
@calkinsh calkinsh merged commit 903b5a0 into main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IG V2 Business Writing: Family IG V2 Business Writing: Conditions/Phenotype
4 participants