fix: sonarqube reliability issues #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,28 +76,28 @@ public async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymou | |||
| participantEligibleResponse = await markParticipantAsEligible(participantCsvRecord); | |||
|
|
|||
| _logger.LogInformation("The participant has not been updated but a validation Exception was raised"); | |||
| responseDataFromCohort = await SendToCohortDistribution(participant, participantCsvRecord.FileName, req); | |||
There was a problem hiding this comment.
are we sure we don't need to pass the request into this method?
There was a problem hiding this comment.
It's not used in the SendToCohortDistribution method for anything.
|
|
I accidentally merged these changes into my other sonar qube PR, so these changes are now in here: |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes all 38 remaining medium reliability sonarqube issues.
Most of these issues involve updating to async methods.
As I was working on these affected files, I fixed any other sonarqube errors I also found in them.
Context
https://sonarcloud.io/project/issues?impactSeverities=MEDIUM&impactSoftwareQualities=RELIABILITY&issueStatuses=OPEN%2CCONFIRMED&id=NHSDigital_dtos-cohort-manager
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.