Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding demographic durable function to allow for adding of 50,000 records #505

Open
wants to merge 95 commits into
base: main
Choose a base branch
from

Conversation

SamRobinson75684
Copy link
Contributor

Description

these changes are to allow for adding larger files, up to 50,000 records. this solution uses a durable function and batches records into the database for demographic data

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

SamRobinson75684 and others added 12 commits December 13, 2024 08:24
* feat: DTOS 00000 adding backup storage redundancy and setting it to local

* feat: DTOS 00000 adding backup storage redundancy and setting it to local tfm fmt run

* feat: DTOS 00000 adding backup storage redundancy and setting it to local pipeline ref updated
…24 (#493)

* feat: DTOS 00000 enrolling ParticipantManagementDataService to int and preprod off pr

* feat: added exception function to demographic and sorted the docker script

* feat: increased the DB SKU to reflect current settings

* fix: linting issue in preprod.tfvars

* feat: change the PreProd SQL SKU to S3

* fix: comment the new function from docker image generation for now

---------

Co-authored-by: Maciej Murawski <maciej.murawski@nordcloud.com>
* feat: add get primary care provider db lookup

* feat: move chained rules into separate method

* feat: dblookup to get bso code using primary care provider

* feat: add extra bso dblookup

* chore: rename pcp bso lookup to avoid clash with existing bso lookup

* feat: move reason for removal transformations into separate class
* pagination

* chore: added total pages, items and current page methods and to result object

* chore: method name and formatting

* feat: logic fix and added in comments

* chore: update tests, DI - pagination service

* chore: whitespace

* fix: currentPage logic fix
* Add peering dendency checks

* Increase database max size
<ProjectReference Include="..\..\Shared\DataServices.Database\DataServices.Database.csproj" />
<ProjectReference Include="..\..\Shared\DataServices.Client\DataServices.Client.csproj" />
</ItemGroup>
<Target Name="CopyGrpcNativeAssetsToOutDir" AfterTargets="Build"> <ItemGroup> <NativeAssetToCopy Condition="$([MSBuild]::IsOSPlatform('OSX'))" Include="$(OutDir)runtimes/osx-arm64/native/*" /> </ItemGroup> <Copy SourceFiles="@(NativeAssetToCopy)" DestinationFolder="$(OutDir).azurefunctions/runtimes/osx-arm64/native" /> </Target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure what this is and why its needed. Its specifically referencing OSX which is concerning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed to be able to run the durable on Mac. for now Microsoft does not fully support Mac silicon for the durable functions. I have pushed the function to azure and it runs in linux in azure and works perfectly. taking this out will not allow us to run this locally on MAC OS. this gives us the packages and things we need that windows has by default

Copy link

sonarqubecloud bot commented Jan 8, 2025

@SamRobinson75684 SamRobinson75684 marked this pull request as ready for review January 8, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants