Code

Audit PR against master with no fees#39

Code

Draft

tomwade wants to merge 54 commits intomaster-no-feesNFTX-project/nftx-protocol-v2:master-no-feesfrom feature/audit-prNFTX-project/nftx-protocol-v2:feature/audit-prCopy head branch name to clipboard

+31,728-8,548

Commits

Commits on Sep 14, 2022

• Add Merkle eligibility logic for ENS vaults (#24)

  

  Tom Wade

  authored and

  tomwade

  committed
  36c4aa1

  Copy full SHA for 36c4aa1

• Merge pull request #27 from NFTX-project/feature/ens-eligibility

  Show description for 617511d
  

  Capsicle1

  authored and

  tomwade

  committed
  617511d

  Copy full SHA for 617511d

• Update merkle to allow as implementation (#28)

  tomwade

  committed
  8271faa

  Copy full SHA for 8271faa

• Optimise ENS merkle flow (#29)

  tomwade

  committed
  cacf3dc

  Copy full SHA for cacf3dc

• Add 0x Marketplace Zap (#18)

  tomwade

  committed
  cbc680f

  Copy full SHA for cbc680f

• Allow merkle eligibility expiration check in init_bytes rather than constructor (#30)

  tomwade

  committed
  ab63212

  Copy full SHA for ab63212

Commits on Nov 2, 2022

• Squashed commit of the following:

  Show description for bf0c0ea
  tomwade

  committed
  bf0c0ea

  Copy full SHA for bf0c0ea

• initial commit

  tomwade

  committed
  bb115b8

  Copy full SHA for bb115b8

• Add return value

  tomwade

  committed
  978fe3d

  Copy full SHA for 978fe3d

• Bypass local stack variable issues

  tomwade

  committed
  4fe40bb

  Copy full SHA for 4fe40bb

• Update minting flow

  tomwade

  committed
  2aa3289

  Copy full SHA for 2aa3289

• Make _getBoolean pure

  tomwade

  committed
  d489bff

  Copy full SHA for d489bff

• Add 1155 support

  tomwade

  committed
  ed2b935

  Copy full SHA for ed2b935

• Move fee allocation

  tomwade

  committed
  5bcbfa0

  Copy full SHA for 5bcbfa0

• Add code commenting

  tomwade

  committed
  6612894

  Copy full SHA for 6612894

• Fix documentation

  tomwade

  committed
  b39b43d

  Copy full SHA for b39b43d

• Remove console logging

  tomwade

  committed
  ccb05f1

  Copy full SHA for ccb05f1

• Enable gas reporting

  Show description for 9e4c633
  tomwade

  committed
  9e4c633

  Copy full SHA for 9e4c633

• Comments and 1155 test

  tomwade

  committed
  1d48ee5

  Copy full SHA for 1d48ee5

• Fix 1155 recipient address going to vault

  tomwade

  committed
  5ac99dd

  Copy full SHA for 5ac99dd

• Enable minting in 1155 test

  tomwade

  committed
  9b7c5e0

  Copy full SHA for 9b7c5e0

• Add 1155 support

  tomwade

  committed
  7dd5fd2

  Copy full SHA for 7dd5fd2

• Convert binary to uint

  tomwade

  committed
  df7681b

  Copy full SHA for df7681b

• All 0 value for eligibility index

  tomwade

  committed
  a2e57b9

  Copy full SHA for a2e57b9

• Add deploy script

  Show description for 660d2cb
  tomwade

  committed
  660d2cb

  Copy full SHA for 660d2cb

• Add liquidity and inventory staking support

  tomwade

  committed
  f6f7669

  Copy full SHA for f6f7669

• Use SushiHelper

  Show description for 514ed4a
  tomwade

  committed
  514ed4a

  Copy full SHA for 514ed4a

• Add new test suite

  Show description for 4f62b52
  tomwade

  committed
  4f62b52

  Copy full SHA for 4f62b52

• Fix variable casing

  tomwade

  committed
  a90cb55

  Copy full SHA for a90cb55

• Update LP staking to be a mock

  tomwade

  committed
  56080c2

  Copy full SHA for 56080c2

• Revert "Enable gas reporting"

  Show description for 0d7a444
  tomwade

  committed
  0d7a444

  Copy full SHA for 0d7a444

• Revert "Squashed commit of the following:"

  Show description for 9e023eb
  tomwade

  committed
  9e023eb

  Copy full SHA for 9e023eb

• Add Yield Staking Zap

  tomwade

  committed
  9765a61

  Copy full SHA for 9765a61

• Add test and deploy script

  Show description for 670be82
  tomwade

  committed
  670be82

  Copy full SHA for 670be82

• Update tests

  Show description for 7129174
  tomwade

  committed
  7129174

  Copy full SHA for 7129174

• Staking updates

  tomwade

  committed
  6b84ef6

  Copy full SHA for 6b84ef6

• Updates

  tomwade

  committed
  592006f

  Copy full SHA for 592006f

• Fix typos

  tomwade

  committed
  f2de783

  Copy full SHA for f2de783

• Update to use minTokenIn

  tomwade

  committed
  df0df34

  Copy full SHA for df0df34

• Make swap target immutable on deployment

  tomwade

  committed
  2376611

  Copy full SHA for 2376611

• Use a mapping for zap contracts

  tomwade

  committed
  6dc9a71

  Copy full SHA for 6dc9a71

• Update test constructors

  tomwade

  committed
  aed6db5

  Copy full SHA for aed6db5

• Add DustReturned event

  tomwade

  committed
  a27ff85

  Copy full SHA for a27ff85

• Update to fix contract issues

  tomwade

  committed
  4350a5f

  Copy full SHA for 4350a5f

• Add MANY fixes

  Show description for 8e76199
  tomwade

  committed
  8e76199

  Copy full SHA for 8e76199

• Add payable

  tomwade

  committed
  cc2c7fa

  Copy full SHA for cc2c7fa

• Fix typos (onlyOnwer)

  tomwade

  committed
  8b77e06

  Copy full SHA for 8b77e06

• Move paused check to modifier

  tomwade

  committed
  573765b

  Copy full SHA for 573765b

• Move modifier to external functions

  tomwade

  committed
  7100c93

  Copy full SHA for 7100c93

• Make swap target immutable

  tomwade

  committed
  7760d1b

  Copy full SHA for 7760d1b

• Ensure address is payable

  tomwade

  committed
  2e04c82

  Copy full SHA for 2e04c82

• Add tests for pausing logic

  tomwade

  committed
  1bd12ae

  Copy full SHA for 1bd12ae

• Remove unused BASE variable

  tomwade

  committed
  4dd1e6a

  Copy full SHA for 4dd1e6a

• Update to goerli key

  tomwade

  committed
  97aa8e3

  Copy full SHA for 97aa8e3