Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix automatic release name #1356

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: fix automatic release name #1356

merged 1 commit into from
Jan 6, 2025

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Jan 6, 2025

Related Ticket: #1347

Description of Changes

I don't think this is the reason why the release versioning was wrong, but it is a fix that needs to go in anyway. (All other places use small v for release)

Notes

Not a blocker but I found out that with --ci flag, the conventional changelog is not being generated properly 🤔 I would like to investigate a bit more

with out --ci flag, I get a changelog like below, grouped with each header

Changelog:
## [5.12.0](https://github.com/NASA-IMPACT/veda-ui/compare/v5.11.4...v5.12.0) (2025-01-06)
### Features
* infile ([1f70d63](https://github.com/NASA-IMPACT/veda-ui/commit/1f70d6302660284e30ffd1abb1d9de4f58758cee))
* temp ([aa6a2f7](https://github.com/NASA-IMPACT/veda-ui/commit/aa6a2f731b8392d319bdf44352fb4d02091a59e3))
### Bug Fixes
* fix release prefix ([b989be3](https://github.com/NASA-IMPACT/veda-ui/commit/b989be397fd77ccca67b64883c966b0832231642))
* order ([4c459fe](https://github.com/NASA-IMPACT/veda-ui/commit/4c459feee047433b15ac6f94f2f78b4a344cb251))

but with --ci flag, I get all the change mushed together. like the one in this release: https://github.com/NASA-IMPACT/veda-ui/releases/tag/v5.11.4 EDIT: it is not --ci flag, I am not sure what is triggering this unexpected bahvior

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 3184f0a
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/677c101dc554fa0008e5aa6e
😎 Deploy Preview https://deploy-preview-1356--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here merged commit 1cc8824 into main Jan 6, 2025
14 checks passed
@hanbyul-here hanbyul-here deleted the 1347-conv branch January 6, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants