-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] v5.12.0 #1300
[RELEASE] v5.12.0 #1300
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Need to add a new task_type for release candidate PR's to pass title check. Proposed pr solution: #1302 |
A couple questions on the cookie consent colors:
I only ask, because I think there should be more color contrast in this alert. Maybe it's just button styling, though. Curious what @faustoperez thinks. |
Yes, these colors are temporary color settings applied by the newly exposed controls, for the cookie consent form:https://github.com/NASA-IMPACT/veda-ui/blob/0d7709ae46316f1adc32dbfb907874e63b8d6d2c/mock/veda.config.js#L94-L112Ï In the situation that they would like to change these colors they only need to change the desired colors in the |
👋 Heads-up that this change was released as v5.11.3 - https://github.com/NASA-IMPACT/veda-ui/releases/tag/v5.11.3 If we want a proper version (as v5.12.0), we can sort things out (manually deleting tag ... etc.) and release v5.12. |
@hanbyul-here does v5.11.3 include everything that was listed in the original comment for v5.12.0 here? It's a little hard to tell from the page you linked |
@aboydnw Yes it does. The changelog is not complete because some of the PRs were merged not following conventional commits - I will go over this in tomorrow's dev sync. |
@hanbyul-here was successful with the initial run of the automated release functionality. Deleting this PR. |
🚀 Improvements
🐛 Fixes