Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] v5.12.0 #1300

Closed
wants to merge 1 commit into from
Closed

[RELEASE] v5.12.0 #1300

wants to merge 1 commit into from

Conversation

snmln
Copy link
Contributor

@snmln snmln commented Dec 6, 2024

🚀 Improvements

🐛 Fixes

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 0d7709a
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6753192504f9f40008539a0f
😎 Deploy Preview https://deploy-preview-1300--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@snmln snmln changed the title [RELEASE] v5.12.0 [fix] v5.12.0 Dec 6, 2024
@snmln snmln changed the title [fix] v5.12.0 [RELEASE] v5.12.0 Dec 6, 2024
@snmln snmln changed the title [RELEASE] v5.12.0 fix: [RELEASE] v5.12.0 Dec 6, 2024
@snmln snmln changed the title fix: [RELEASE] v5.12.0 [RELEASE] v5.12.0 Dec 6, 2024
@snmln
Copy link
Contributor Author

snmln commented Dec 6, 2024

Need to add a new task_type for release candidate PR's to pass title check. Proposed pr solution: #1302

@snmln snmln mentioned this pull request Dec 6, 2024
@aboydnw
Copy link
Contributor

aboydnw commented Dec 6, 2024

A couple questions on the cookie consent colors:

  1. Does the cookie consent alert have these colors because of the styled colors in this instance?
  2. Is it possible for instance managers to customize these colors (aka, adjust only the colors in the cookie consent, without causing changes to styling in the rest of the app?

I only ask, because I think there should be more color contrast in this alert. Maybe it's just button styling, though. Curious what @faustoperez thinks.
image

@snmln
Copy link
Contributor Author

snmln commented Dec 6, 2024

A couple questions on the cookie consent colors:

  1. Does the cookie consent alert have these colors because of the styled colors in this instance?
  2. Is it possible for instance managers to customize these colors (aka, adjust only the colors in the cookie consent, without causing changes to styling in the rest of the app?

I only ask, because I think there should be more color contrast in this alert. Maybe it's just button styling, though. Curious what @faustoperez thinks. image

Yes, these colors are temporary color settings applied by the newly exposed controls, for the cookie consent form:https://github.com/NASA-IMPACT/veda-ui/blob/0d7709ae46316f1adc32dbfb907874e63b8d6d2c/mock/veda.config.js#L94-L112Ï

In the situation that they would like to change these colors they only need to change the desired colors in the veda.config.js

@aboydnw
Copy link
Contributor

aboydnw commented Dec 6, 2024

Okay, great. Thanks for the additional info @snmln

I did the usual manual test and didn't find anything wrong. When we get #1302 sorted, this looks good from my end

@hanbyul-here
Copy link
Collaborator

👋 Heads-up that this change was released as v5.11.3 - https://github.com/NASA-IMPACT/veda-ui/releases/tag/v5.11.3 If we want a proper version (as v5.12.0), we can sort things out (manually deleting tag ... etc.) and release v5.12.

@aboydnw
Copy link
Contributor

aboydnw commented Dec 9, 2024

@hanbyul-here does v5.11.3 include everything that was listed in the original comment for v5.12.0 here? It's a little hard to tell from the page you linked

@hanbyul-here
Copy link
Collaborator

@aboydnw Yes it does. The changelog is not complete because some of the PRs were merged not following conventional commits - I will go over this in tomorrow's dev sync.

@snmln
Copy link
Contributor Author

snmln commented Dec 10, 2024

@hanbyul-here was successful with the initial run of the automated release functionality. Deleting this PR.

@snmln snmln closed this Dec 10, 2024
@hanbyul-here hanbyul-here deleted the release/v5.12.0 branch December 10, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants