chore: local dev setup fixes #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliziel
commented
Oct 29, 2024
| @@ -155,7 +155,7 @@ plan-%: install | |||
| ## pre-deploy-setup: Setup resources prior to initial deployment (idempotent) | |||
| pre-deploy-setup: all-init | |||
| # Ensure buckets exist, grab the name of the "internal" bucket, and copy launchpad.pfx there. | |||
| $(DOCKER_RUN) --interactive $(IMAGE) -ic "bin/ensure-buckets-exist.sh 2>/dev/null | |||
| $(DOCKER_RUN) --interactive $(IMAGE) -ic "bin/ensure-buckets-exist.sh 2>/dev/null" | |||
There was a problem hiding this comment.
$ make pre-deploy-setup
# ...
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [pre-deploy-setup] Error 2
aliziel
commented
Oct 29, 2024
aliziel
commented
Oct 29, 2024
app/stacks/post-deploy-mods/main.tf
Outdated
There was a problem hiding this comment.
$ git commit
Terraspace Format........................................................Failed
- hook id: terraspace-fmt
- exit code: 1
- files were modified by this hook
aliziel
commented
Oct 29, 2024
| @@ -10,7 +10,8 @@ echo -n "Determining provider bucket..." | |||
| provider_bucket="$( | |||
| echo 'var.buckets["provider"]["name"]' | | |||
| terraspace console cumulus 2>/dev/null | | |||
| grep "${CUMULUS_PREFIX}" | |||
| grep "${CUMULUS_PREFIX}" | | |||
| sed -E 's/"(.+)"/\1/' | |||
There was a problem hiding this comment.
$ make create-test-data
Determining provider bucket..."csda-cumulus-ali-provider-7894"
Syncing dummy files to provider bucket "csda-cumulus-ali-provider-7894"...fatal error: Parameter validation failed:
Invalid bucket name ""csda-cumulus-ali-provider-7894"": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]*:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-.]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$"
make: *** [create-test-data] Error 1
There was a problem hiding this comment.
Strange. I wonder if output changed with a recent version of terraform or terraspace, since this didn't have this problem before.
There was a problem hiding this comment.
That was my guess, but I couldn't (easily) find Terraspace change history to confirm. I actually aligned with existing handling here, so it might've changed around that time since the DevEx work surrounding the sandbox tickets looked pretty thoroughly tested 🤷
There was a problem hiding this comment.
Ah, yes, perhaps just something missed back then.
chuckwondo
reviewed
Oct 29, 2024
Co-authored-by: Chuck Daniels <chuck@developmentseed.org>
jsrikish
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
I recently spun up a Cumulus instance in the CBA sandbox account to help test the CNM work and encountered a couple hiccups on a fresh install (nothing Cumulus-related on my machine before this).
This branch is mostly fixing typos + populating env vars for local dev — no functional changes to live code.
How I did it
$DOTENVinzip_lambdashellpre-deploy-setuptargetterraspace fmton post-deploy-mods/main.tf (blocking commit on unrelated files)How you can test it
The following commands should run successfully
$ make pre-deploy-setup # also verifies the zip_lambda target $ make create-test-data