fix: correctly handle get_proof for contract without a root index
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whichqua
changed the title
get_proof correctly handle contract without a root index
whichqua
changed the title
get_proof correctly handle contract without a root indexget_proof for contract without a root index
Key changes include:
- Adjusting the get_proof method to return an empty list when no contract root is found.
- Adding checks for None values when retrieving contract roots.
Pathfinder returns an internal error when one tries to fetch a proof for contract with a `contract_state_hash` but without a `root_index` for the current block height. Pathfinder returns none which is propagated down to an internal error.
The following is an example of a request that fails without this fix:
```json
{
"id": "0",
"jsonrpc": "2.0",
"method": "pathfinder_getProof",
"params": {
"block_id": {
"block_number": 155006
},
"contract_address": "0x40a29e36c82f868dc2b5712bc6729c6132ca75ae46d6c75718ecbd49a0c9fb7",
"keys": [
"0x206f38f7e4f15e87567361213c28f235cccdaa1d7fd34c9db1dfe9489c6a091"
]
}
}
```
When there is no root_index, this fix will return empty `ProofNodes` ie `ProofNodes(vec![])` for each of the keys.
This fix also prevents multiple calls to the database fetching the same root (same contract and block number) while looping through the keys.
whichqua
force-pushed
the
gm/return-empty-proofs-if-no-root
branch
from
8f08993 to
aa96876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a nutshell
Key changes include:
Problem:
Pathfinder returns an internal error when one tries to fetch a proof for contract with a
contract_state_hashbut without aroot_indexfor the current block height. Pathfinder returns none which is propagated down to an internal error.Replication
The following is an example of a request that fails without this fix:
{ "id": "0", "jsonrpc": "2.0", "method": "pathfinder_getProof", "params": { "block_id": { "block_number": 155006 }, "contract_address": "0x40a29e36c82f868dc2b5712bc6729c6132ca75ae46d6c75718ecbd49a0c9fb7", "keys": [ "0x206f38f7e4f15e87567361213c28f235cccdaa1d7fd34c9db1dfe9489c6a091" ] } }Solution:
When there is no root_index, this fix will return empty
ProofNodesieProofNodes(vec![])for each of the keys.Extras
This fix also prevents multiple calls to the database fetching the same root (same contract and block number) while looping through the keys.