Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleep before running acc tests #440

Merged
merged 3 commits into from
Aug 9, 2024
Merged

sleep before running acc tests #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af259f4
sleep before running acc tests
Mongey Aug 9, 2024
8ff1a6b
disable
Mongey Aug 9, 2024
419d394
Allow more time to produce messages
Mongey Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ jobs:
restore-keys: |
${{ runner.os }}-go-
- name: Bring up kafka + zk
run: docker compose up -d
run: docker compose up -d --wait
- name: "Run tests"
run: make testacc
run: sleep 10 && make testacc
1 change: 0 additions & 1 deletion GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ testacc:
KAFKA_CLIENT_KEY_PASSPHRASE=test-pass \
KAFKA_SKIP_VERIFY=false \
KAFKA_ENABLE_TLS=true \
TF_LOG=DEBUG \
TF_ACC=1 go test ./kafka -v $(TESTARGS) -timeout 9m -count=1

.PHONY: build test testacc
1 change: 1 addition & 0 deletions kafka/resource_kafka_topic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ func testResourceTopic_produceMessages(messages []*sarama.ProducerMessage) r.Tes
kafkaConfig.Producer.Return.Errors = true
kafkaConfig.Producer.Return.Successes = true
kafkaConfig.Producer.RequiredAcks = sarama.WaitForAll
kafkaConfig.Producer.Timeout = 90 * time.Second

producer, err := sarama.NewSyncProducer(*config.BootstrapServers, kafkaConfig)
if err != nil {
Expand Down
Loading