Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新审核系统上线 #592

Merged
merged 5 commits into from
Jan 12, 2025
Merged

feat: 新审核系统上线 #592

merged 5 commits into from
Jan 12, 2025

Conversation

lovelyCARDINAL
Copy link
Member

@lovelyCARDINAL lovelyCARDINAL commented Jan 11, 2025

@AnnAngela 需要改一下批量传图工具,传图会返回moderation-image-queued,需要视为上传成功

Summary by Sourcery

启动一个新的审核系统,将"moderation-image-queued"视为成功上传,并增强用户消息模板以提高清晰度。此外,禁用审核状态配置中的编辑权限。

新功能:

  • 引入一个新的审核系统,通过将"moderation-image-queued"视为成功上传来处理图像上传。

增强:

  • 更新审核状态配置,禁用编辑权限。
  • 在 MediaWiki 小工具中优化用户消息模板,提高清晰度。
Original summary in English

Summary by Sourcery

Launch a new moderation system that treats 'moderation-image-queued' as a successful upload and enhance user message templates for improved clarity. Additionally, disable edit rights in the moderation status configuration.

New Features:

  • Introduce a new moderation system that handles image uploads by treating 'moderation-image-queued' as a successful upload.

Enhancements:

  • Update the moderation status configuration by disabling edit rights.
  • Refine user message templates for better clarity in the MediaWiki gadget.

Copy link

sourcery-ai bot commented Jan 11, 2025

审阅者指南 by Sourcery

这个拉取请求引入了对审核系统的更改,包括更新权限配置、修正用户消息中的拼写错误,以及修改移动到用户子页面工具以提高功能性。

显示审核状态配置更改的类图

classDiagram
    class ModerationStatus {
        -rights: string[]
    }
    note for ModerationStatus "权限从 'edit' 更改为 'disabled'"
Loading

显示移动到用户子页面工具修改的类图

classDiagram
    class MoveToUserSubpage {
        +move(page: string)
        +moveTalk: boolean
        +reason: string
        +noredirect: boolean
        +watchAfter: string
    }
    note for MoveToUserSubpage "从原因参数中移除 '//noredirect' 后缀"
Loading

文件级别更改

更改 详情 文件
更新审核状态权限配置。
  • 将权限从 'edit' 更改为 'disabled'。
src/gadgets/ModerationStatus/definition.yaml
修正用户消息配置中的拼写错误。
  • 修复 'NavSort' 用户消息模板中的拼写错误。
src/gadgets/UserMessages/MediaWiki:Gadget-UserMessages.js
修改移动到用户子页面工具以改进功能。
  • 从移动到用户子页面工具的原因字段中移除 '//noredirect'。
src/gadgets/moveToUserSubpage/MediaWiki:Gadget-moveToUserSubpage.js

提示和命令

与 Sourcery 交互

  • 触发新的审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复评论,要求 Sourcery 从审阅评论创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您还可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request introduces changes to the moderation system, including updating rights configurations, correcting a typo in user messages, and modifying the move to user subpage tool for better functionality.

Class diagram showing changes to ModerationStatus configuration

classDiagram
    class ModerationStatus {
        -rights: string[]
    }
    note for ModerationStatus "Rights changed from 'edit' to 'disabled'"
Loading

Class diagram showing moveToUserSubpage tool modifications

classDiagram
    class MoveToUserSubpage {
        +move(page: string)
        +moveTalk: boolean
        +reason: string
        +noredirect: boolean
        +watchAfter: string
    }
    note for MoveToUserSubpage "Removed '//noredirect' suffix from reason parameter"
Loading

File-Level Changes

Change Details Files
Updated moderation status rights configuration.
  • Changed rights from 'edit' to 'disabled'.
src/gadgets/ModerationStatus/definition.yaml
Corrected a typo in user messages configuration.
  • Fixed a typo in the user message template for 'NavSort'.
src/gadgets/UserMessages/MediaWiki:Gadget-UserMessages.js
Modified move to user subpage tool to improve functionality.
  • Removed '//noredirect' from the reason field in the moveToUserSubpage tool.
src/gadgets/moveToUserSubpage/MediaWiki:Gadget-moveToUserSubpage.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovelyCARDINAL - 我已经审查了你的更改,看起来非常棒!

以下是我在审查期间关注的内容
  • 🟢 一般性问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @lovelyCARDINAL - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lovelyCARDINAL lovelyCARDINAL merged commit d767d74 into master Jan 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 已完成
Development

Successfully merging this pull request may close these issues.

2 participants