This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add Tests for relic.sga.archive.header.py
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some actual tests
Most likely a bug, will need to test against Dow3 dumps
13 tasks
ModernMAK
changed the title
relic.sga.archive.header.py
Begrudgingly added archive tests Will cry when I break them later Mostly just wanted that pretty green checkmark and to close #12 for good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for checksum validation still need to be performed, but DowI/DowII require full SGA archives to test on; until other SGA tests are done and an SGA can be built and packed programmatically, it isn't worth the effort of handwriting bytes for these testsChecksums added in 985401c; comment's no longer relevant