Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint #23

Merged
merged 2 commits into from
Oct 23, 2024
Merged

chore: fix lint #23

merged 2 commits into from
Oct 23, 2024

Conversation

pythonbrad
Copy link
Contributor

Related issues

Change

  • Apply cargo clippy
  • Fixed code formatting

@pythonbrad pythonbrad marked this pull request as ready for review October 22, 2024 13:38
@Mindful
Copy link
Owner

Mindful commented Oct 22, 2024

LGTM - just one request: can you add a line or two in the readme showing how to run whatever formatter you used to reformat the code (unless you did all the formatting manually...) ? I'm pretty unfamiliar with rust tooling.

@pythonbrad
Copy link
Contributor Author

pythonbrad commented Oct 23, 2024

@Mindful

Cargo comes with this tools.

  • cargo fmt
  • cargo clippy

If you don't use cargo, you can use rustfmtwho comes with rust.

@pythonbrad
Copy link
Contributor Author

To execute it, you can do

cargo fmt src/predict

@Mindful
Copy link
Owner

Mindful commented Oct 23, 2024

Alright, good enough for me.

@Mindful Mindful merged commit e47ab9b into Mindful:main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants