Improve behavior of histogram step input

Handle step down between orders of magnitude and properly enforce max bin count
Mechanical-Advantage · Dec 27, 2024 · a65443a · a65443a
1 parent 55c691e
commit a65443a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/hub/controllers/StatisticsController.ts b/src/hub/controllers/StatisticsController.ts
@@ -42,9 +42,9 @@ export default class StatisticsController implements TabController {
     [this.TIME_RANGE, this.RANGE_MIN, this.RANGE_MAX, this.STEP_SIZE].forEach((input) =>
       input.addEventListener("change", () => (this.shouldUpdate = true))
     );
-    this.STEP_SIZE.addEventListener("change", () => {
-      this.updateHistogramInputs();
-    });
+    [this.RANGE_MIN, this.RANGE_MAX, this.STEP_SIZE].forEach((input) =>
+      input.addEventListener("change", () => this.updateHistogramInputs())
+    );
 
     // Set initial values for histogram inputs
     this.RANGE_MIN.value = "0";
@@ -56,11 +56,11 @@ export default class StatisticsController implements TabController {
   /** Updates the step size for each histogram input. */
   private updateHistogramInputs() {
     if (Number(this.STEP_SIZE.value) <= 0) {
-      this.STEP_SIZE.value = cleanFloat(Number(this.STEP_SIZE.step)).toString();
+      this.STEP_SIZE.value = cleanFloat(Number(this.STEP_SIZE.step) * 0.9).toString();
     }
     let range = Math.abs(Number(this.RANGE_MAX.value) - Number(this.RANGE_MIN.value));
     if (range / Number(this.STEP_SIZE.value) > this.MAX_BINS) {
-      this.STEP_SIZE.value = cleanFloat(Math.ceil(range / this.MAX_BINS)).toString();
+      this.STEP_SIZE.value = cleanFloat(range / this.MAX_BINS).toString();
     }
     let step = Math.pow(10, Math.floor(Math.log10(Number(this.STEP_SIZE.value))));
     this.STEP_SIZE.step = step.toString();