Fix unit conversion for odometry & 3D fields views

Converting to meters actually produced the correct result since both meters and radians are used as base units, but radians is the correct unit here
Mechanical-Advantage · Oct 26, 2023 · 8ab6c35 · 8ab6c35
1 parent f29b9d4
commit 8ab6c35
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/hub/tabControllers/OdometryController.ts b/src/hub/tabControllers/OdometryController.ts
@@ -211,7 +211,7 @@ export default class OdometryController extends TimelineVizController {
 
   getCommand(time: number) {
     const distanceConversion = convert(1, this.UNIT_DISTANCE.value, "meters");
-    const rotationConversion = convert(1, this.UNIT_ROTATION.value, "meters");
+    const rotationConversion = convert(1, this.UNIT_ROTATION.value, "radians");
 
     // Returns the current value for a field
     let getCurrentValue = (key: string, type: LoggableType | string): Pose2d[] => {

diff --git a/src/hub/tabControllers/ThreeDimensionController.ts b/src/hub/tabControllers/ThreeDimensionController.ts
@@ -302,7 +302,7 @@ export default class ThreeDimensionController extends TimelineVizController {
 
   getCommand(time: number) {
     const distanceConversion = convert(1, this.UNIT_DISTANCE.value, "meters");
-    const rotationConversion = convert(1, this.UNIT_ROTATION.value, "meters");
+    const rotationConversion = convert(1, this.UNIT_ROTATION.value, "radians");
 
     // Returns the current value for a 3D field
     let get3DValue = (key: string, type: LoggableType | string): Pose3d[] => {