Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Update #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI Update #29

wants to merge 1 commit into from

Conversation

CMCDragonkai
Copy link
Member

I saw this branch was being used before... but it was never merged. Quite strange?

@CMCDragonkai
Copy link
Member Author

The gitlab ci changes seem unnecessary.

But the strict build changes seem useful?

@CMCDragonkai
Copy link
Member Author

I've removed the commit for the gitlab yaml file.

But I've kept these strict build changes.

Please review @nzhang-zh and see if they should be merged.

Also are strict code being checked by the CI?

@CMCDragonkai
Copy link
Member Author

Now that we 2 "main" branches: master and postgres. After merging into master, these changes must be synced postgres branch. Probably via cherry picking.

@CMCDragonkai
Copy link
Member Author

This has some relationship with #28?

@CMCDragonkai
Copy link
Member Author

This failed hlint and brittany.

Hlint should be fixed easily.

The brittany failure is a mystery.

Not sure why that is happening.

@nzhang-zh
Copy link
Contributor

The gitlab ci changes are obsoleted by #26 .
But I forgot the exact reason why this branch was left unmerged back then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzhang-zh nzhang-zh Awaiting requested review from nzhang-zh

Assignees

@nzhang-zh nzhang-zh

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CMCDragonkai @nzhang-zh