Fix styling issue in Dismissible boxes #2564
Merged
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix styling issue for .dismissible-box .btn-close
where global bootstrap css no longer applied to
component with changed classname
What is the purpose of this pull request?
Fixes #2558
Overview of changes:
Changes in #2487 of class name of body wrapper from
alert-dismissible
toalert-dismissible-box
caused global bootstrap css styles on.alert-dimissible .btn-close
to lose effect, causing this bug.Added back css styles based on bootstrap css to restore original styling.
Testing instructions:
markbind serve -d
.Proposed commit message: (wrap lines at 72 characters)
Fix dismissible-box styling issue
Changes in #2487 renamed the class from
alert-dismissible
toalert-dismissible-box
, causing Bootstrap CSS styles on.alert-dismissible .btn-close
to lose effect.This commit restores the original styling by adding back
the necessary CSS styles to
.alert-dismissible-box .btn-close
.Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):